ARM: Cleanup implementation of ITSTATE and put important code in PCState.
Review Request #616 - Created March 30, 2011 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| Reviewers | |
| Default | |
| ali, gblack, nate, stever | |
ARM: Cleanup implementation of ITSTATE and put important code in PCState. Consolidate all code to handle ITSTATE in the PCState object rather than touching a variety of structures/objects.
Posted (March 30, 2011, 2:53 a.m.)
This is a great change. I saw one style mistake, and also I think some code you moved could be simplified further.
-
src/arch/arm/types.hh (Diff revision 1) -
The type should be on its own line.
-
src/arch/arm/types.hh (Diff revision 1) -
You could add new fields to the ITSTATE bitunion that would make this easier. cond and mask could be SubBitUnions which can be treated as values on their own or have internal bitfields (syntactically, they still have access to everything). This would then look more like: it.cond.bottom = it.mask.top; it.mask = it.mask << 1; if (it.mask == 0) it.cond = 0; You could use _itstate directly as well which would save a few more lines.