Review Board 2.0.15


Ruby: Add new object called WireBuffer to mimic a Wire.

Review Request #627 - Created March 31, 2011 and submitted

Information
Lisa Hsu
gem5
Reviewers
Default
ali, gblack, nate, stever
Ruby: Add new object called WireBuffer to mimic a Wire.
This is a substitute for MessageBuffers between controllers where you don't
want messages to actually go through the Network, because requests/responses can
always get reordered wrt to one another (even if you turn off Randomization and turn on Ordered)
because you are, after all, going through a network with contention. For systems where you model
multiple controllers that are very tightly coupled and do not actually go through a network,
it is a pain to have to write a coherence protocol to account for mixed up request/response orderings
despite the fact that it's completely unrealistic.  This is *not* meant as a substitute for real
MessageBuffers when messages do in fact go over a network.

   
Posted (March 31, 2011, 7:19 a.m.)



  
src/mem/ruby/system/WireBuffer.hh (Diff revision 1)
 
 
Remove the comment.
src/mem/ruby/system/WireBuffer.hh (Diff revision 1)
 
 
Remove this line as well.
src/mem/ruby/system/WireBuffer.py (Diff revision 1)
 
 
Do we need this commented piece of code?
  1. Thanks for catching these.  I thought I cleaned up that stuff, but I obviously missed some.  Thanks!
Ship it!
Posted (March 31, 2011, 9:01 a.m.)
Other than Nilay's comments, this looks good to me.