ruby: dbg: use system ticks instead of cycles
Review Request #635 - Created April 5, 2011 and submitted
| Information | |
|---|---|
| Korey Sewell | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
| ali, gblack, nate, stever | |
ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time
Posted (April 7, 2011, 9:27 a.m.)
-
src/mem/ruby/network/simple/PerfectSwitch.cc (Diff revision 1) -
If DPRINTF() prints the time, is this piece of code required?
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
Again, do we need curTick() here?
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
Same comment as before.
Posted (April 7, 2011, 2:39 p.m.)
-
src/mem/ruby/network/simple/PerfectSwitch.cc (Diff revision 1) -
You are probably right here. No need to print out the time 2x. A slightly different scenario for DPRINTFRs though.
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
DPRINTFR doesnt print the tick, but DPRINTF does print the tick. curTick() is needed here.
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
Ditto about DPRINTFR which doesnt automatically print out the ticks for you.
Posted (April 8, 2011, 1:54 a.m.)
Overall, this seems pretty straightforward. However I'm confused by the double curTick concerns. Specific comments below.
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
If we are going to replace the cycle count with curTick(), then we should increase the width of that first field well beyond 7. Something like 15 makes sense to me. What do you think? Also I'm confused by Nilay's concern about printing out the curTick twice. DPRINTFR doesn't print out the curTick by default, correct? Therefore the current tick will only be printed once.
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
Same thing here. Increase first field well beyond 7.
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 1) -
beyond 7
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 1) -
beyond 7
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 1) -
beyond 7
Just a few minor alignment requests. Other than that, it looks good to me.
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 2) -
Since you're already modifying this DPRINTFR, can you align all the lines to the open paranethesis? Thanks
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 2) -
align here please
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 2) -
align here please