Translation: Use a pointer type as the template argument.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

Translation: Use a pointer type as the template argument.

This allows regular pointers and reference counted pointers without having to
use any shim structures or other tricks.

Testing Done

Diff:

Revision 2 (+23 -22)

Show changes

	src/cpu/base_dyn_inst.hh
	src/cpu/translation.hh
	src/cpu/simple/timing.cc

Looks fine to me... A quick check to verify that we don't have a memory leak would be nice.

Gabe Black July 10, 2011, 5:35 p.m. (July 10, 2011, 5:35 p.m.)

I'm running the X86_FS o3 regression right now as part of trying to get it to work, and it's been running for a while doing a bunch of translations and hasn't exploded in memory usage. I think it's ok because O3 has a check if too many dynInsts are outstanding. I wouldn't consider either of these really rigorous checks (there could be one or two leaked under just the right circumstances) but it seems to be ok.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Diff: