GARNET: adding a fault model for resilient on-chip network research.
Review Request #776 - Created July 8, 2011 and submitted
| Information | |
|---|---|
| Konstantinos Aisopos | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
| ali, beckmann, gblack, nate, stever, tushar | |
GARNET: adding a fault model for resilient on-chip network research. This patch adds a fault model, which provides the probability of a number of architectural faults in the interconnection network (e.g., data corruption, misrouting). These probabilities can be used to realistically inject faults in GARNET and faithfully evaluate the effectiveness of novel resilient NoC architectures.
Posted (July 11, 2011, 4:38 a.m.)
Is it necessary for the fault model to be configured using a text file? Can you do this in python instead? For instance, if you used scripts to generate the files, it would be best if you implemented those scripts in python and used the standard sim_object methodology. Also is the one text file just a "temp" file? If so, should it be checked it?
Review request changed
Updated (Aug. 10, 2011, 7:46 a.m.)
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+814 -1) |
Posted (Aug. 16, 2011, 3:18 p.m.)
Thanks for the update. This is much cleaner! My only major comment is be consistent with your spacing between operators and operands. I only identified a couple of lines where there should be spaces, but there are many other lines that need spacing. Other than that and one more minor question below, this patch looks good to me.
-
src/mem/ruby/network/fault_model/FaultModel.cc (Diff revision 2) -
Why 12? If this is a constant, please use a const int or define a macro. Also please add a space between math operators and operands: ex" "int i = 0;"
-
src/mem/ruby/network/fault_model/FaultModel.cc (Diff revision 2) -
Spacing here too... Ex. "number_of_inputs <= 0"
-
src/mem/ruby/network/garnet/BaseGarnetNetwork.py (Diff revision 2) -
If the fault model only works with the fixed network, shouldn't these parameters be moved to the fixed network python class and not the base network class?
Review request changed
Updated (Aug. 17, 2011, 9:12 a.m.)
Posted (Aug. 17, 2011, 10:56 a.m.)
-
src/mem/ruby/network/fault_model/FaultModel.cc (Diff revision 3) -
Could move this (everything from Official tool to the end) into separate comments? We have some scripts that check and grab copyright from all files and I'd prefer not to have to add a special exception for this. For all files please.
Review request changed
Updated (Aug. 17, 2011, 11:09 a.m.)
Diff: |
Revision 4 (+819 -1)
|
|---|
Posted (Aug. 18, 2011, 3:58 a.m.)
It looks like you fixed some of the hardcoded numbers, but not all of them. Some places still hardcode values to 2 or 12.
-
src/mem/ruby/network/fault_model/FaultModel.cc (Diff revision 4) -
Still using a hardcoded 12 here.
Review request changed
Updated (Aug. 18, 2011, 7:58 a.m.)
Diff: |
Revision 5 (+842 -1)
|
|---|
Thanks for you hard work. This looks good to me.
