params.py: enhance IpAddress param handling

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

params.py: enhance IpAddress param handling

Print IpAddress params in dot notation for readability.
Properly compare IpAddress objects (by value and not object identity).
Also fix up derived param classes (IpNetmask and IpWithPort)
similarly.

Testing Done

a tad

src/python/m5/params.py (Diff revision 1)

Should other object have operators for comparison?  Should we have something that's in a superclass?

src/python/m5/params.py (Diff revision 1)

Is this clearer than [24,16,8,0]?

Nathan Binkert July 21, 2011, 2:18 a.m. (July 21, 2011, 2:18 a.m.)

Heh, I didn't notice that, but I must agree that Ali's version is better (and shorter).  You could even use a tuple instead of a list to make it faster! :P

Steve Reinhardt July 21, 2011, 3:25 a.m. (July 21, 2011, 3:25 a.m.)

Come on, clearly my version is more flexible... what if we switch to IPv6?  Or what if the number of bits in a byte changes?  :-)

Diff:

Revision 2 (+47 -10)

Show changes

src/python/m5/params.py

Change Summary:

Updated to use Ali's shorter brute-force byte offset list.
Fixed bug where comparison with inappropriate strings caused a ValueError
rather than just returning False.
Extended to handle IpAddress subclasses too.

Description:

		params.py: enhance IpAddress param handling

		Print IpAddress params in dot notation for readability.
~		Properly compare IpAddress objects (by value and not object identity).
	~	Properly compare IpAddress objects (by value and not object identity).
	+	Also fix up derived param classes (IpNetmask and IpWithPort)
	+	similarly.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Diff:

Change Summary:

Description: