Review Board 2.0.15


SLICC: Put functions of a controller in its .cc file

Review Request #809 - Created July 26, 2011 and submitted

Information
Nilay Vaish
gem5
default
Reviewers
Default 
SLICC: Put functions of a controller in its .cc file
Currently, functions associated with a controller go into separate files.
This patch puts all the functions in the controller's .cc file. This should
hopefully take away some time from compilation.
Compiles cleanly.
Nathan Binkert
Posted (July 27, 2011, 5:07 a.m.)



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/mem/slicc/symbols/Func.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Should this function exist?  Is it still called?  I'd think that you could remove this now.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Nate, when I remove it, python complains that 'Func' object has no attribute 
'writeCodeFiles'. I looked in to SymbolTable.py and writeCodeFiles() is called
on all the symbols. Should not that mean that Func class should have writeCodeFiles()
defined? Similarly Var.py also has a writeCodeFiles() function which does nothing.
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    I guess if Var is done the same way, then we can keep it.  We can clean this up in the future.  (FYI, I doubt that this has a noticeable impact on compile time).
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    I took only one time measure and that too without the -j option. The 
difference was about 20s. I think with -j, there would be negligible impact.
    
    
    
   
    4.