Review Board 2.0.15


IDE: Fix issues with new PIIX kernel driver and our model.

Review Request #820 - Created Aug. 9, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ali, gblack, nate, stever 
IDE: Fix issues with new PIIX kernel driver and our model.

The driver can read the IDE config register as a 32 bit register since
some adapters use bit 18 as a disable channel bit. If the size isn't
set in a PRD it should be 64K according to the SPEC (and driver) not
128K.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Steve Reinhardt

   
Posted  (Sept. 12, 2011, 1:59 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/dev/ide_ctrl.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
need braces here and below per style guide (at least I thought that was in the style guide...)




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/dev/ide_disk.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
is this a whitespace change?




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/dev/ide_disk.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
seems odd to add a new dprintf here that's identical to (but not control-exclusive with) the one below