Stack: Tidy up some comments, a warning, and make stack extension consistent.
Review Request #839 - Created Sept. 5, 2011 and submitted
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| Reviewers | |
| Default | |
| ali, gblack, nate, stever | |
Stack: Tidy up some comments, a warning, and make stack extension consistent. Do some minor cleanup of some recently added comments, a warning, and change other instances of stack extension to be like what's now being done for x86.
Posted (Sept. 6, 2011, 3:08 a.m.)
-
src/arch/x86/tlb.cc (Diff revision 1) -
Could a lot of this go into a doxygen comment for checkAndAllocNextPage()?
Posted (Sept. 7, 2011, 5:04 a.m.)
Looking at this now, I'd say the #1 problem is with the function name checkAndAllocNextPage, which manages to be underinformative despite being long and unwieldy. If we worked the term "stack" into that function name somewhere it would help a lot. How about changing it to something like "tryStackAllocation()"? Also, since Ali mentioned doxygen comments, I checked the comment for this function in process.hh and not only is it not doxygen formatted, but it's plain misleading (it should just say that the return value indicates success, not that we're about to panic). Seems like this would be a good time to fix that too.
Other than the minor rephrasing of the comment, this looks great to me.
-
src/sim/process.hh (Diff revision 2) -
Minor nit: "if the fault should be fixed" is a little ambiguous (should be fixed already, or should be fixed by the caller)? How about: /// @return True if the fault has been fixed.