Review Board 2.0.15


event: minor cleanup

Review Request #845 - Created Sept. 6, 2011 and submitted

Information
Steve Reinhardt
gem5
Reviewers
Default
ali, gblack, nate, stever 
event: minor cleanup
Initialize flags via the Event constructor instead of calling
setFlags() in the body of the derived class's constructor.  I
forget exactly why, but this made life easier when implementing
multi-queue support.

Also rename Event::getFlags() to isFlagSet() to better match
common usage, and get rid of some unused Event methods.

   

  


 


 

  

  









  
 


  

 


















 

  


 


  



   

   
Steve Reinhardt

   
Posted  (Sept. 22, 2011, 3:42 a.m.)


  


  


  

   
bump... even though this is change only needed for the multi-event-queue patch, it'd be nice to get it committed so I don't need to maintain it separately



  

   

   
    
    
   


  





  

 


  

 



















 

  


 


  




   
Ship it!



   

   
Ali Saidi

   
Posted  (Sept. 22, 2011, 4:12 a.m.)


  


  


  

   
seems fine to me; just seems semantic.



  

   

   
    
    
   


  





  

 


  

 

















 



 

  


 


  




   
Ship it!



   

   
Nathan Binkert

   
Posted  (Sept. 22, 2011, 4:25 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/sim/eventq.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Seems that we should be embedding _curTick in the event queue itself, providing a function something like this and making the global curTick() call mainEventQueue.foo()




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    With my multi-queue code there's a TLS pointer to the thread's current event queue, so it should work fine to put curTick in the queue.  My only concern is performance; I don't know how often we reference curTick and whether the extra indirection would be a noticeable hit or not.

That said, no one was using this particular function anyway.  We can always recreate it if needed.

    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Oh sure.  I'm not suggesting that you don't remove it now and recreate it later, just what I was thinking of as a goal.

As for the extra indirection, it seems to me that it is pretty rare that you'd need to call curTick without needing anything else from the event queue.  Also, if the eventq is a global, is there any extra indirection?  The eventq is simply an offset in the globals and curTick is an offset within that.  With TLS, it's basically the same as well.  In fact, is there really an extra indirection ever?

    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    Good point... you're right, probably not.
    
    
    
   
    4.