Review Board 2.0.15


SCons: Make the ISA parser a source for its output files like the comments say.

Review Request #875 - Created Sept. 23, 2011 and submitted

Information
Gabe Black
gem5
Reviewers
Default
ali, gblack, nate, stever 
SCons: Make the ISA parser a source for its output files like the comments say.

There was a change a while ago that refactored some scons stuff which got rid
of cpu_models.py but also accidentally got rid of the ISA parser as a source
for its target files. That meant that changes which affected the parser
wouldn't cause a rebuild unless they also changed one of the description
files. This change fixes that.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  




   
Ship it!



   

   
Steve Reinhardt

   
Posted  (Sept. 24, 2011, 12:51 a.m.)


  


  


  

   
Looks good. Comment is just a suggestion.



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/arch/SConscript
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Be nice to have a comment here like:
# skip isa_parser in source[1]
...though that makes me wonder what's in source[0]... is that the ISA desc input itself?