Review Board 2.0.15


config: Added the topology name to m5 & ruby output

Review Request #88 - Created Aug. 5, 2010 and submitted

Information
Brad Beckmann
gem5
Reviewers
Default
config: Added the topology name to m5 & ruby output

   
Posted (Aug. 12, 2010, 3:53 a.m.)
This works, so I hate to complain, but it would be a lot more pythonic to turn topologies into a Python package (add an __init__.py file) and turn all the makeTopology() methods into __init__ methods on the respective Topology subclasses.  You might even be able to change the default for the description param into Self.__class__.__name__ and then you wouldn't have to set it explicitly (though I'm not 100% sure that would work, since proxies like Self are really only designed to work with Param attributes).

Anyway, I thought I'd throw this out there and see what Nate thinks...
  1. That might be outside the scope of this patch, but I totally agree that we should convert things to packages.