Ruby: Make it so that controllers attached to Sequencers don't have to be named L1Cache.

Information
Submitter:	Lisa Hsu
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

Ruby: Make it so that controllers attached to Sequencers don't have to be named L1Cache.

Testing Done

src/mem/slicc/symbols/StateMachine.py (Diff revision 1)

Lisa, this line does not appear in the current version of gem5. You may want to update your version before committing this change.

Lisa Hsu Oct. 12, 2011, 3:07 a.m. (Oct. 12, 2011, 3:07 a.m.)

Thanks Nilay.  I didn't bother to pop off all the internal patches before doing this review, but I will before pushing, if it gets past you :).

src/mem/slicc/symbols/StateMachine.py (Diff revision 1)

Why do we have loop here? Can a controller be associated with multiple sequencers?

Lisa Hsu Oct. 12, 2011, 3:07 a.m. (Oct. 12, 2011, 3:07 a.m.)
```
Yes, it can.  There's no inherent limit to being 1:1.
```

This patch looks fine, though others should be aware that arbitrary controller names is not yet supported by RubySlicc_ComponentMapping.hh.  Therefore routing messages to these controllers, while still passing the regression tester may be difficult.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)