The placement of the mfence microops looks fine, and the implementation of the microop is probably correct. There are some things to fix, but the substance of this change looks good. As always x86 and o3 are both pretty tricky, so please test carefully once you fixed the issues.

src/arch/x86/isa/microops/fenceop.isa (Diff revision 1)

If you make this its own file, you should probably use the copyright used for most of the files and assign it to an appropriate organization. I don't think we really have any specific association with HP any more.

I would suggest putting this in the specop.isa file. That's for one off, special microops, and I think this fits into that category pretty solidly.

src/arch/x86/isa/microops/fenceop.isa (Diff revision 1)

You should be able to use BasicExecute, BasicDecode, etc., from arch/x86/isa/formats/basic.isa. Since this microop does literally nothing, it shouldn't have any unusual requirements other than setting flags appropriately. You should be able to do that using all or mostly just the Basic templates.

1. Nilay Vaish Nov. 2, 2011, 2:56 a.m. (Nov. 2, 2011, 2:56 a.m.)

   I think using only Basic templates is not possible. The declaration
   template does not add X86ISA to the declaration, it only adds the class
   mentioned in the InstObjParam. If I add X86ISA::<> to the InstObjParam,
   the constructor definition becomes a problem.

src/arch/x86/isa/microops/fenceop.isa (Diff revision 1)

From here down is the only part that you really need to add to specop.isa