Review Board 2.0.15


Output: Add hierarchical output support and cleanup existing codebase.

Review Request #902 - Created Nov. 3, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ali, gblack, nate, stever 
Output: Add hierarchical output support and cleanup existing codebase.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Gabe Black

   
Posted  (Nov. 5, 2011, 6:06 p.m.)


  


  


  

   
After a mostly superficial look through it seems pretty good, other than a few minor style nits. This looks pretty familiar. Did this already get posted for review? I think this is Nate's stuff, so we should wait to hear from him before committing anything.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Yes a long time ago,  but the feedback was to chop it in 2 pieces. 
    
    
    
   
    2. 

   


  




   







    

     
     

      

       
        

         
          src/base/output.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Functions shouldn't have the { on the same line as the function name.




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/base/output.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
This shouldn't all be one line.




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/base/output.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Should this be a fatal or panic? I guess it depends on if the bad choice of directory was gem5's fault or the users. I don't think this is wrong or right, just wanted to point it out.