SPARC: Fixing a minor copy-paste bug using the wrong variable

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	ali, gblack, nate, stever

Description

SPARC: Fixing a minor copy-paste bug using the wrong variable

There was a bug in the mm_disk implementation where a copy paste error
resulted in the d32 variable not being initialised (as it incorrectly
was used instead of d16), and gcc 4.5 complaining.

Testing Done

No testing of SPARC_FS since I do not have access to and do not know where to find the reset_new.bin and other files required.

This change looks right, although I haven't looked at it really closely. Thank you for sharing your fix with us. Your commit message isn't in the right format, though. It's not at all obvious, but there's a brief explanation of what it should look like under "Details" here:

http://www.gem5.org/Commit_Access

Also, you should run the SPARC_FS regressions since that's where the devices are used.

Summary:

-	Fixing a minor bug in the mm_disk implementation where a copy paste
+	SPARC: Fixing a minor copy-paste bug using the wrong variable

Description:

~		Fixing a minor bug in the mm_disk implementation where a copy paste
~		error resulted in the d32 variable not being initialised (as it
~		incorrectly was used instead of d16), and gcc 4.5 complaining.
	~	SPARC: Fixing a minor copy-paste bug using the wrong variable
	~
	~	There was a bug in the mm_disk implementation where a copy paste error
	+	resulted in the d32 variable not being initialised (as it incorrectly
	+	was used instead of d16), and gcc 4.5 complaining.

Diff:

Revision 2 (+1 -1)

Show changes

src/dev/sparc/mm_disk.cc

Testing Done:

~		All SPARC_SE opt pass
	~	No testing of SPARC_FS since I do not have access to and do not know where to find the reset_new.bin and other files required.

Since we don't have a working sparc FS regression, nor do people without access to zizze have a file system, this will have to do.

Gabe Black Nov. 25, 2011, 9:01 a.m. (Nov. 25, 2011, 9:01 a.m.)

Yes, I agree. The change looks very reasonable so I'm confident it's correct, but I'll run it myself just to be sure. Do you have commit access, or do you need somebody to put it in for you?

Gabe Black Nov. 25, 2011, 10:17 a.m. (Nov. 25, 2011, 10:17 a.m.)
```
It passed so you're good to go.
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Diff:

Testing Done: