memtest: Memtester support for DMA

Information
Submitter:	Brad Beckmann
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

memtest: Memtester support for DMA

This patch adds DMA testing to the Memtester and is inherits many changes from
Polina's old tester_dma_extension patch.

Testing Done

src/cpu/memtest/MemTest.py (Diff revision 1)

is_dma seems like a strange name.  Something like use_dma or issue_dmas might be better.  Also, everything else is a percentage.  How often do you issue DMAs here?  I think you should either specify it somewhere in a comment or make it a percentage to begin with.  Or is it that all requests are DMAs?  Don't you want to interleave them?

src/cpu/memtest/memtest.cc (Diff revision 1)

This seems like an unrelated change.

Diff:

Revision 2 (+114 -32)

Show changes

	configs/example/memtest-ruby.py
	configs/ruby/MESI_CMP_directory.py
	configs/ruby/MI_example.py
	configs/ruby/MOESI_CMP_directory.py
	configs/ruby/MOESI_CMP_token.py
	configs/ruby/MOESI_hammer.py
	src/cpu/memtest/MemTest.py
	src/cpu/memtest/memtest.hh
	3 more

It looks like you removed a whole lot of features in this diff.  Why did you do this?  Can you explain it in the commit message?

Brad Beckmann Aug. 12, 2010, 1:30 a.m. (Aug. 12, 2010, 1:30 a.m.)

Ruby doesn't work in atomic mode.  Therefore it doesn't make sense to have atomic mode options in this file.  Sure, I'll update the commit message.

configs/example/memtest-ruby.py (Diff revision 2)

Why did you remove this stuff?

configs/example/memtest-ruby.py (Diff revision 2)

What does this mean?  Can you add some help?

Brad Beckmann Aug. 12, 2010, 1:29 a.m. (Aug. 12, 2010, 1:29 a.m.)

Similar to --num-cpus, this is the number of dma testers.  I added a help message.

configs/example/memtest-ruby.py (Diff revision 2)

Why remove this?

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Diff: