Review Board 2.0.15


O3: Remove some asserts that no longer seem to be valid.

Review Request #931 - Created Dec. 16, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
O3: Remove some asserts that no longer seem to be valid.

We've been running with these removed for (and they're not actually present in opt/fast) for months now. I'm convinced this assert is no longer valid.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Steve Reinhardt

   
Posted  (Jan. 4, 2012, 12:01 p.m.)


  


  


  

   
I'm confused.  Do they assert when they're enabled?



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Yes. These things have been in there forever and I think I'm the third person to say that the assert must be wrong because we constantly run with opt/fast with these asserts removed without issue. 
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Makes sense now.  Looks good to me.  I'd click "ship it" if you could do that inside a nested comment.
    
    
    
   
    3.