MAC: Make gem5 compile and run on MacOSX 10.7.2
Review Request #940 - Created Dec. 18, 2011 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
MAC: Make gem5 compile and run on MacOSX 10.7.2 Adaptations to make gem5 compile and run on OSX 10.7.2, with a stock gcc 4.2.1 and the remaining dependencies from macports, i.e. python 2.7,.2 swig 2.0.4, mercurial 2.0. The changes include an adaptation of the SConstruct to handle non-library linker flags, and Darwin-specific code to find the memory usage of gem5. A number of Ruby files relied on ambigious uint (without the 32 suffix) which caused compilation errors.
util/regress all passing (disregarding t1000 and eio)
Style problems, but otherwise seems ok.
-
ext/libelf/SConscript (Diff revision 1) -
You have a space after the first [ but not before the last ]
-
src/base/hostinfo.cc (Diff revision 1) -
Bad indentation. This isn't in your change but it would be good to fix.
-
src/base/hostinfo.cc (Diff revision 1) -
Return type on its own line.
-
src/base/hostinfo.cc (Diff revision 1) -
Bad indentation.
Thanks!
Review request changed
Updated (Dec. 22, 2011, 4:56 p.m.)
Diff: |
Revision 2 (+58 -20) |
|---|