eventq: add a function for replacing head of the queue
Review Request #967 - Created Jan. 3, 2012 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
eventq: add a function for replacing head of the queue This patch adds a function for replacing the event at the head of the queue with another event. This helps in running a different set of events. Events already scheduled can processed by replacing the original head event back. This function has been specifically added to support cache warmup and cooldown required for creating and restoring checkpoints.
Posted (Jan. 3, 2012, 8:37 a.m.)
-
src/sim/eventq.hh (Diff revision 1) -
I still think that this needs better explanation and a big "DANGER" in the comment itself. Explain that you're doing this specifically for cache warm up and you had better know what you're doing if you're going to use this interface. I also think that the definition for this function should go in the .cc file. To me, it's the type of thing that you definitely don't want inlined.
Review request changed
Updated (Jan. 4, 2012, 5:02 a.m.)
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+16) |
Posted (Jan. 4, 2012, 5:13 a.m.)
-
src/sim/eventq.hh (Diff revision 2) -
How about a doxygen comment
Review request changed
Updated (Jan. 4, 2012, 5:21 a.m.)
Diff: |
Revision 3 (+18) |
|---|
-
src/sim/eventq.hh (Diff revision 3) -
Excellent! I like the warning. Please include one where you actually use the function as well.