inorder-arm: make arm InOrderCPU compilable
Review Request #1013 - Created Jan. 26, 2012 and discarded
| Information | |
|---|---|
| Korey Sewell | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
inorder-arm: make arm InOrderCPU compilable
Issue Summary
3
3
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Since you're saying which particular mode, you probably should drop the "an". | Gabe Black | Jan. 26, 2012, 5:27 p.m. | Open |
| A lot of these headers aren't needed. using namespace std; isn't needed either. | Gabe Black | Jan. 26, 2012, 5:27 p.m. | Open |
| It's outside the scope of this change, but these functions are only ever going to do something on MIPS, and ... | Gabe Black | Jan. 26, 2012, 5:27 p.m. | Open |
Posted (Jan. 26, 2012, 5:27 p.m.)
-
src/arch/arm/isa.hh (Diff revision 1) -
Since you're saying which particular mode, you probably should drop the "an".
-
src/arch/arm/mt.hh (Diff revision 1) -
A lot of these headers aren't needed. using namespace std; isn't needed either.
-
src/arch/arm/mt.hh (Diff revision 1) -
It's outside the scope of this change, but these functions are only ever going to do something on MIPS, and if they're ever called anywhere else the simulation will die. I'd really love to see them go away at some point. It's like how Henry Ford said you could get your car in any color, as long as it's black. You can call these functions in any ISA, as long as its MIPS.
Posted (Jan. 27, 2012, 12:35 p.m.)
What Gabe said, then I'm happy too...