ARM: Fix a number of small bugs we've found.
Review Request #1174 - Created May 2, 2012 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8978:5119c5ee2bea --------------------------- ARM: Fix a number of small bugs we've found.
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Somebody went a little crazy with the parenthesis, but not a big deal. | Gabe Black | May 5, 2012, 7:13 p.m. | Open |
Posted (May 2, 2012, 6:22 a.m.)
Each bug should get its own CL and own commit message. Otherwise the history is useless.
Posted (May 2, 2012, 7:17 a.m.)
-
src/arch/arm/miscregs.cc (Diff revision 1) -
missing break statements that would index the wrong register if the cases wern't fully populated.
-
src/base/output.cc (Diff revision 1) -
improper use of ? : such that the ile was always opened in binary mode
-
src/cpu/checker/cpu.cc (Diff revision 1) -
use after delete
-
src/cpu/checker/cpu.cc (Diff revision 1) -
use after delete
-
src/cpu/pc_event.cc (Diff revision 1) -
improper use of the erase() function and then incrementing an invalid iterator.
-
src/dev/arm/gic.cc (Diff revision 1) -
asserts to make sure that you're not indexing too far
-
src/dev/arm/rtc_pl031.cc (Diff revision 1) -
logically this is a not not a bitwise
-
src/dev/arm/rv_ctrl.cc (Diff revision 1) -
always printed warning because of missing berak
-
src/dev/simple_disk.cc (Diff revision 1) -
wrong delete type
-
src/mem/cache/cache_impl.hh (Diff revision 1) -
loop always had a break after one iteration, so it shouldn't be a loop
-
src/mem/cache/mshr.cc (Diff revision 1) -
lack of break statements meant that s always was ""
-
src/mem/cache/prefetch/base.cc (Diff revision 1) -
improper use of erase() on an interator
-
src/mem/fs_translating_port_proxy.cc (Diff revision 1) -
never executed because dst was never null and it was supposed to be the dereferenced version
-
src/sim/eventq.hh (Diff revision 1) -
use after free
Ship It!
Thanks. These all look good to me with the minor complaint below.
-
src/dev/arm/gic.cc (Diff revision 1) -
Somebody went a little crazy with the parenthesis, but not a big deal.