DMA: Split the DMA device and IO device into seperate files

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

DMA: Split the DMA device and IO device into seperate files

This patch moves the DMA device to its own set of files, splitting it
from the IO device. There are no behavioural changes associated with
this patch.

The patch also grabs the opportunity to do some very minor tidying up,
including some white space removal and pruning some redundant
parameters.

Besides the immediate benefits of the separation-of-concerns, this
patch also makes upcoming changes more streamlined as it split the
devices that are only slaves and the DMA device that also acts as a
master.

Testing Done

util/regress all passing (disregarding t1000 and eio)

Issue Summary

Description	From	Last Updated	Status
This doesn't seem like it adds any value	Ali Saidi	May 22, 2012, 12:10 a.m.	Dropped

i don't know that it makes it better or worse, but if you care...

src/dev/Device.py (Diff revision 1)

This doesn't seem like it adds any value

Show all issues

Andreas Hansson May 20, 2012, 5:26 p.m. (May 20, 2012, 5:26 p.m.)

I am a bit unsure what "this" refers to. The DmaDevice is moved to DmaDevice.py

Ali Saidi May 21, 2012, 12:31 p.m. (May 21, 2012, 12:31 p.m.)

That is what I mean, why move it?

Is that better that just from Device import DmaDevice?

Andreas Hansson May 21, 2012, 5:19 p.m. (May 21, 2012, 5:19 p.m.)

Ah ok, it is mostly to reflect the change in the C++ code, splitting the slave-only devices, and the master-and-slave-devices, but by all means, the change of the py file is questionable. We can skip that part and keep it in Device.py if desirable. Anyone else, opinions? Otherwise I move it back.

I'm with Ali... I wouldn't call this a badly needed improvement, but it's fine with me.  I'm happy either way on the DmaDevice.py change.  I'd lean towards not changing it just because it's a user-visible change that might require people to tweak their config scripts, which is better to avoid when it's not necessary.

Andreas Hansson May 22, 2012, 12:10 a.m. (May 22, 2012, 12:10 a.m.)
```
Great. I'll skip the splitting of the Python file.
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)