Cache: Remove redundant check for uncacheable snoops

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Cache: Remove redundant check for uncacheable snoops

This patch removes the check for uncacheable requests in the cache
snoop timing/atomic access methods. This check is now taken care of by
the bus, and there is no need to perform it also in the caches.

Testing Done

util/regress all passing (disregarding t1000 and eio)

Issue Summary

Description	From	Last Updated	Status
Seems fine for the normal case, but if you hookde two caches up directly, would this break?	Ali Saidi	May 20, 2012, 12:54 a.m.	Open

src/mem/cache/cache_impl.hh (Diff revision 1)

Seems fine for the normal case, but if you hookde two caches up directly, would this break?

Show all issues

Andreas Hansson May 20, 2012, 5:28 p.m. (May 20, 2012, 5:28 p.m.)

Very valid point. Would that even work today? I am tempted to bet against...but perhaps that's just me being overly cynical.

As a very minor side note, there are quite a few limitations already in what connectivity is allowed, e.g. two buses cannot be directly connected.

Ali Saidi May 21, 2012, 12:32 p.m. (May 21, 2012, 12:32 p.m.)

I'm fairly certain that it would work, or at least it did at one point in time.

Andreas Hansson May 21, 2012, 5:17 p.m. (May 21, 2012, 5:17 p.m.)

Ok, in that case we can keep the check. I'll discard the patch. If we want that case to work we should probably add a regression.

You have a pending review.

Review Board 2.0.15

This change has been discarded.

Screenshots

Files

Issue Summary

Status: Discarded