ARM: Keep a copy of the fpscr len and stride fields in the decoder.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9032:a43d6b23beec
---------------------------
ARM: Keep a copy of the fpscr len and stride fields in the decoder.

Avoid reading them every instruction, and also eliminate the last use of the
thread context in the decoders.

Testing Done

Issue Summary

Description	From	Last Updated	Status
space	Ali Saidi	May 28, 2012, 12:11 a.m.	Open

Ali Saidi May 28, 2012, 12:45 a.m. (May 28, 2012, 12:45 a.m.)

did you happen to see if this improved performance? I imagine it would.

Gabe Black May 28, 2012, 7:10 a.m. (May 28, 2012, 7:10 a.m.)

For twolf on simple atomic

original:

host_seconds                                    80.03
host_seconds                                    79.97
host_seconds                                    80.16

new:

host_seconds                                    73.04
host_seconds                                    72.95
host_seconds                                    73.47

src/arch/arm/remote_gdb.cc (Diff revision 1)

space

Show all issues

Gabe Black May 28, 2012, 7:10 a.m. (May 28, 2012, 7:10 a.m.)

You're right that there should be a space, but it's a pre-existing condition that matches the rest of the file. It should be cleaned up in a later change, but for now it's better for it to be consistently wrong.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)