Ruby: convert cache memory stats to gem5's style
Review Request #1293 - Created July 5, 2012 and discarded
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9088:dd6c331371c1 --------------------------- Ruby: convert cache memory stats to gem5's style
Issue Summary
2
2
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Just a bit surprised at the method of turning RubyRequestType_NUM into an int. Intentional? Why not (int) or static_cast<int>? | Andreas Hansson | July 5, 2012, 3:02 a.m. | Open |
| Is this change intended to be part of this patch? | Andreas Hansson | July 5, 2012, 3:02 a.m. | Open |
Posted (July 5, 2012, 3:02 a.m.)
-
src/mem/ruby/system/CacheMemory.cc (Diff revision 1) -
Just a bit surprised at the method of turning RubyRequestType_NUM into an int. Intentional? Why not (int) or static_cast<int>?
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 1) -
Is this change intended to be part of this patch?
Posted (July 10, 2012, 4:56 a.m.)
Nilay, can you hold off checking this patch in until I commit my changes. We have a lot of internal code that uses the current Cache Profiler that I'll need to change. I'd rather not do that in the next few weeks. This patch reminds me of a larger question that is worth revisiting. Is now the time to convert Ruby stats to gem5 stats, since gem5 stats are now python objects and can potentially be outputted in any format. The last half of that statement may be a streach, so please correct me if that's untrue. As you know, I've been relucant to convert Ruby stats to gem5 stats because many Ruby stats are useful in the debugging process, and Ruby's more condense format is much more readable. Meanwhile, the default gem5 stats format is optimized for data extraction. If we could use the new python support to generate an output file that looks a lot like the current ruby.stats file, then now maybe a good time to switch. This is probably a better topic for a separate thread, but I wanted to mention that thought before I forgot.
