sim: Make clock private and access using clockPeriod()

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9544:d8e3bd9d3fc2
---------------------------
sim: Make clock private and access using clockPeriod()

This patch makes the clock member private to the ClockedObject and
forces all children to access it using clockPeriod(). This makes it
impossible to inadvertently change the clock, and also makes it easier
to transition to a situation where the clock is derived from e.g. a
clock domain, or through a multiplier.

Testing Done

All regressions passing (excluding t1000 and eio)

src/mem/bus.cc (Diff revision 1)

Why do you need the casting?

src/mem/bus.cc (Diff revision 1)

You can do (dataSize + width - 1 / width) and remove the modulo operation and the increment.

Steve Reinhardt Feb. 16, 2013, 3:28 a.m. (Feb. 16, 2013, 3:28 a.m.)
```
Far better yet, use divCeil() from base/intmath.hh
```

Description:

~		Changeset 9516:594f7b965eea
	~	Changeset 9544:d8e3bd9d3fc2

		sim: Make clock private and access using clockPeriod()

		This patch makes the clock member private to the ClockedObject and
		forces all children to access it using clockPeriod(). This makes it
		impossible to inadvertently change the clock, and also makes it easier
		to transition to a situation where the clock is derived from e.g. a
		clock domain, or through a multiplier.

Diff:

Revision 2 (+49 -57)

Show changes

	src/dev/arm/timer_cpulocal.hh
	src/dev/arm/timer_cpulocal.cc
	src/mem/bus.hh
	src/mem/bus.cc
	src/mem/coherent_bus.hh
	src/mem/coherent_bus.cc
	src/mem/noncoherent_bus.hh
	src/mem/noncoherent_bus.cc
	4 more

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 9516:594f7b965eea

Changeset 9544:d8e3bd9d3fc2

Diff:

Status: Closed (submitted)