mem: Enforce strict use of busFirst- and busLastWordTime
Review Request #1715 - Created Feb. 13, 2013 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9521:523d0e0d4f36 --------------------------- mem: Enforce strict use of busFirst- and busLastWordTime This patch adds a check to ensure that the delay incurred by the bus is not simply disregarded, but accounted for by someone. At this point, all the modules do is to zero it out, and no additional time is spent. This highlights where the bus timing is simply dropped instead of being paid for. As a follow up, the locations identified in this patch should add this additional time to the packets in one way or another. For now it simply acts as a sanity check and highlights where the delay is simply ignored. Since no time is added, all regressions remain the same.
All regressions passing (excluding t1000 and eio)
Posted (Feb. 16, 2013, 4 a.m.)
This looks useful for identifying where we've messed up, but of course it would be better to fix the problem... what do you think of my earlier suggestion, where we schedule the transmission events at busLastWordTime by default, unless the slave specifically indicates that it wants them at busFirstWordTime instead? I'm beginning to think that might actually be a reasonable idea.
Ship It!