Review Board 2.0.15


CPU: Make Exec trace to print predication result (if false) for memory instructions

Review Request #180 - Created Aug. 13, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
CPU: Make Exec trace to print predication result (if false) for memory instructions

   

  


 


 

  

  









  
 


  

 


















 

  


 


  



   

   
Gabe Black

   
Posted  (Aug. 13, 2010, 4:55 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/cpu/exetrace.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
How about "false predicate" instead? I don't think the word predicate is being used right here. This is partially just personal taste.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    A search of papers for "predicate false" returns a lot of hits, so it has been used before.

    
    
    
   
    2. 

   


  


    


   



  

 


  

 

















 



 

  


 


  



   

   
Gabe Black

   
Posted  (Aug. 13, 2010, 4:58 p.m.)


  


  


  

   
Oh, I should have also suggested changing the predicatedFalse stuff to just predicate or maybe predicateVal. That gets rid of the inversion where it's true if the predicate was false, and it's a little more concise.