Sequencers: Reset clocks after cache warmup/cooldown

Information
Submitter:	Joel Hestness
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9634:4a87fbab0988
---------------------------
Sequencers: Reset clocks after cache warmup/cooldown

Sequencers can be accessed by CPU cores after cache warm-up or cool-down but
before their clocks have been reset in normal simulation, which can cause
MessageBuffer assertion failures that the enqueue time of a message is later
than the send time. This change ensures that the Sequencer clocks are reset
after warm-up and cool-down to avoid this problem.

Testing Done

Numerous checkpoint restore tests with x86 + Ruby

I am not sure if this is required. Which revision are you working with?

Joel Hestness April 8, 2013, 8:20 a.m. (April 8, 2013, 8:20 a.m.)

I only witnessed the bug that this patch fixes and thoroughly tested the patch with revision 9478.

The assertion that was failing when I ran this was MessageBuffer.cc:212:

    assert(m_clockobj_ptr->curCycle() >= msg_ptr->getLastEnqueueTime() &&
           "ensure we aren't dequeued early");

I just spent some time in the repo site and found this assertion has been updated in changeset 9603:bf5e46a02a38 (March 22), which addresses the same checkpoint/restore bug that this patch does. My apologies for not catching that here (this patch has been in our queue since March 9).  I will drop this request.

You have a pending review.

Review Board 2.0.15

This change has been discarded.

Screenshots

Files

Status: Discarded