Review Board 2.0.15


x86: Fix the flag handling code in FABS and FCHS

Review Request #1919 - Created June 10, 2013 and submitted

Information
Andreas Sandberg
gem5
default
Reviewers
Default
Changeset 9756:0f18925d4ae4
---------------------------
x86: Fix the flag handling code in FABS and FCHS

This changeset fixes two problems in the FABS and FCHS
implementation. First, the ISA parser expects the assignment in
flag_code to be a pure assignment and not an and-assignment, which
leads to the isa_parser omitting the misc reg update. Second, the FCHS
and FABS macro-ops don't set the SetStatus flag, which means that the
default micro-op version, which doesn't update FSW, is executed.

   
Review request changed
Updated (June 18, 2013, 7:08 a.m.)

Status: Closed (submitted)