cpu: Move the branch predictor out of the BaseCPU

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9845:73704b98a61d
---------------------------
cpu: Move the branch predictor out of the BaseCPU

The branch predictor is guarded by having either the in-order or
out-of-order CPU as one of the available CPU models and therefore
should not be used in the BaseCPU. This patch moves the parameter to
the relevant CPU classes.

Testing Done

All regressions pass

At some point of time, I was planning to add branch predictor state
to the checkpoint. Typically, we create checkpoint using the atomic
or the simple timing cpu. Therefore, I had added branch predictor
to the base cpu.

Andreas Hansson Aug. 27, 2013, 8:09 a.m. (Aug. 27, 2013, 8:09 a.m.)

Perhaps I'm missing something, but if it is always null for these CPUs, then there won't be any state to restore anyways. Right?

Andreas Hansson Aug. 28, 2013, 12:38 a.m. (Aug. 28, 2013, 12:38 a.m.)

As this is needed for the NULL ISA patches, I'd be very keen to see this go out as is for now. If there are reasons to change things at a later stage, then let's worry about it when we get to that point. Ok?

Andreas Hansson Aug. 30, 2013, 1:52 a.m. (Aug. 30, 2013, 1:52 a.m.)
```
Nilay, is that ok with you?
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)