Review Board 2.0.15


Mem: Finish half-baked support for mmaping file in physmem.

Review Request #259 - Created Oct. 2, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
Mem: Finish half-baked support for mmaping file in physmem.

Physmem has a parameter to be able to mem map a file, however
it isn't actually used. This changeset utilizes the parameter
so a file can be mmapped.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Steve Reinhardt

   
Posted  (Oct. 15, 2010, 10:49 a.m.)


  


  


  

   
I realize these names predate this patch, but your changes make it evident that cachedSize and cachedStart are actually kind of dumb names, so this might be a good time to fix that.  Since these are really just member variables that have accessors, shouldn't they be named _size and _start?




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    They have accessors? We could add some, but I don't think they have any.
    
    
    
   
    2.