ruby: declare all protocol message buffers as parameters
Review Request #3001 - Created Aug. 2, 2015 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11016:efd32f38e069 --------------------------- ruby: declare all protocol message buffers as parameters MessageBuffer is a SimObject now. There were protocols that still declared some of the message buffers are variables of the controller, but not as input parameters. Special handling was required for these variables in the SLICC compiler. This patch changes this. Now all message buffers are declared as input parameters.
Wow... wish I had thought to do this so it could have been checked in with the rest of the MessageBuffer SimObject patch. I hope we can get it in soon.
@Brad and/or AMD crew: If you see this review, I'd recommend checking out this patch soon, since it could save some time merging with MessageBuffer changes I just pushed.
-
src/mem/protocol/Network_test-dir.sm (Diff revision 1) -
Can you please remove this change from the patch?
Posted (Aug. 30, 2015, 10:48 a.m.)
Do we need any further discussion on this? Planning to commit in a week.
