mem: Add callback to compute stats prior to dump event

Information
Submitter:	Curtis Dunham
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:	myzinsky

Description

The per rank statistics are periodically updated based on
state transition and refresh events.

Add a method to update these when a dump event occurs to
ensure they reflect accurate values.
Specifically, need to ensure that the low-power state
durations, power, and energy are logged correctly.

Change-Id: Ib642a6668340de8f494a608bb34982e58ba7f1eb
Reviewed-by: Radhika Jagtap <radhika.jagtap@arm.com>

Testing Done

Issue Summary

Description	From	Last Updated	Status
Should this be here? Or in the constructor or ::init()? I'm not sure where the right place is.. but I ...	Jason Lowe-Power	Sept. 28, 2016, 3:53 p.m.	Dropped

People:

+	myzinsky

Just a small thing below. Other than that it looks good.

src/mem/dram_ctrl.cc (Diff revision 1)

Should this be here? Or in the constructor or ::init()?

I'm not sure where the right place is.. but I don't think that regStats() is it. I think it's kind of hidden here.

Show all issues

Wendy Elsasser Sept. 28, 2016, 3:46 p.m. (Sept. 28, 2016, 3:46 p.m.)

It was placed here as it's used to update the power / energy values each time statistics are dumped during a simulation to include values up to that point.

While it may be hidden, it is providing the right function. Comments?

Jason Lowe-Power Sept. 28, 2016, 3:55 p.m. (Sept. 28, 2016, 3:55 p.m.)

Sure. I just looked it up in the current codebase. In Ruby all of the registerDumpCallback calls are in the constructor, but there are 3 other instances of this function and they are all in regStats(). So, keeping it where you have it is following some convention ;). Leaving it this way is fine with me.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

People:

Status: Closed (submitted)