misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10]

Information
Submitter:	Christian Menard
Repository:	gem5
Branch:	default
Bugs:
Depends On:	~~3528~~
Blocks:	3695
Reviewers
Groups:	Default
People:

Description

Changeset 11796:362dd9be3b96
---------------------------
misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10]

The current TLM bridge only provides a Slave Port that allows the gem5 world to
send request to the SystemC world. This patch series refractors and cleans up
the existing code, and adds a Master Port that allows the SystemC world to send
requests to the gem5 world.

This patch:
* Simplify the Slave Port by using a simple_initiator_socket.

Testing Done

Example applications are still running.

Somehow the patch is not displaying. Did you use hg postreview?

Christian Menard Oct. 27, 2016, 2:37 a.m. (Oct. 27, 2016, 2:37 a.m.)

Hi Andreas! Thanks for your reviews, I will give them a look soon. I wanted to do some cleaning up anyway as there are still some inconsistencies in master and slave port.

I uploaded the patches manually since I don't have the postreview extension. Where can I get it? The link on the wiki is broken.

Andreas Hansson Oct. 27, 2016, 2:59 a.m. (Oct. 27, 2016, 2:59 a.m.)
```
No worries. The link is updated.
```

Summary:

-	misc: use a simple_initiator_socket to implement the SystemC TLM slave port
+	misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port

Description:

~		This patch simplifies the implementation of the SystemC TLM slave port.
	~	Changeset 11691:9733d3adf993
	+	---------------------------
	+	misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port

Branch:

+	default

Diff:

Revision 2 (+7 -20)

Show changes

	util/tlm/sc_slave_port.hh
	util/tlm/sc_slave_port.cc

Ship It!

Ship It!

Summary:

-	misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port
+	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]

Description:

~		Changeset 11691:9733d3adf993
	~	Changeset 11796:5a238973b456
		---------------------------
~		misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port
	~	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]
	+
	+	The current TLM bridge only provides a Slave Port that allows the gem5 world to
	+	send request to the SystemC world. This patch series refractors and cleans up
	+	the existing code, and adds a Master Port that allows the SystemC world to send
	+	requests to the gem5 world.
	+
	+	This patch:
	+	* Simplify the Slave Port by using a simple_initiator_socket.

Diff:

Revision 3 (+7 -20)

Show changes

	util/tlm/sc_slave_port.hh
	util/tlm/sc_slave_port.cc

Description:

~		Changeset 11796:5a238973b456
	~	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]
-		---------------------------
-		misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]

		The current TLM bridge only provides a Slave Port that allows the gem5 world to
		send request to the SystemC world. This patch series refractors and cleans up
		the existing code, and adds a Master Port that allows the SystemC world to send
		requests to the gem5 world.

		This patch:
		* Simplify the Slave Port by using a simple_initiator_socket.

Depends On:

-	~~3527 - misc: Clean up and complete the gem5<->SystemC-TLM bridge [1/10]~~
+	~~3528 - misc: Clean up and complete the gem5<->SystemC-TLM bridge [2/10]~~

Description:

~		misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]
	~	Changeset 11796:362dd9be3b96
	+	---------------------------
	+	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]

		The current TLM bridge only provides a Slave Port that allows the gem5 world to
		send request to the SystemC world. This patch series refractors and cleans up
		the existing code, and adds a Master Port that allows the SystemC world to send
		requests to the gem5 world.

		This patch:
		* Simplify the Slave Port by using a simple_initiator_socket.

Diff:

Revision 4 (+7 -20)

Show changes

	util/tlm/sc_slave_port.hh
	util/tlm/sc_slave_port.cc

Ship It!

Summary:

-	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]
+	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10]

Description:

		Changeset 11796:362dd9be3b96
		---------------------------
~		misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/6]
	~	misc: Clean up and complete the gem5<->SystemC-TLM bridge [3/10]

		The current TLM bridge only provides a Slave Port that allows the gem5 world to
		send request to the SystemC world. This patch series refractors and cleans up
		the existing code, and adds a Master Port that allows the SystemC world to send
		requests to the gem5 world.

		This patch:
		* Simplify the Slave Port by using a simple_initiator_socket.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Branch:

Diff:

Summary:

Description:

Diff:

Description:

Depends On:

Description:

Diff:

Summary:

Description:

Status: Closed (submitted)