misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/10]
Review Request #3695 - Created Nov. 7, 2016 and submitted
| Information | |
|---|---|
| Christian Menard | |
| gem5 | |
| default | |
| 3775 | |
| Reviewers | |
| Default | |
Changeset 11813:50707c26c991
---------------------------
misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/10]The current TLM bridge only provides a Slave Port that allows the gem5 world to
send request to the SystemC world. This patch series refractors and cleans up
the existing code, and adds a Master Port that allows the SystemC world to send
requests to the gem5 world.This patch:
* Move common code of the example to a common directory.
* Move the cli parsing from the SimControl module to a separate example object.
* Add comments describing the Gem5SimControl module.
Examples compile and run.
-
util/tlm/gem5_master_transactor.hh (Diff revision 1) -
Add more comments and update the README
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+885 -294) |
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+893 -294) |
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+908 -300) |
Thanks for sorting all this out.
Could you extend the patch description as there is a lot going on in this patch, both in terms of refactoring and adding new functionality? In the future it would be good to split these changes, e.g. "use pkg-config for SystemC example", "make command line interface modular" etc.
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+430 -172) |
Description: |
|
|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+430 -172) |
Ship It!
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 7 (+431 -172) |