Review Board 2.0.15


O3: Send instruction back to fetch on squash to seed predecoder correctly.

Review Request #511 - Created Feb. 25, 2011 and submitted

Information
Ali Saidi
gem5
Reviewers
Default
ali, gblack, nate, stever 
O3: Send instruction back to fetch on squash to seed predecoder correctly.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Gabe Black

   
Posted  (Feb. 26, 2011, 8:55 a.m.)


  


  


  

   
I see what you're doing here, I think. For the strategy your taking your implementation seems ok (other than some weird whitespace), but I'm not sure this is the way to go. The itstate should be part of the pc and then wouldn't depend on anything in the previous instruction. The way you've implemented this forced itstate stuff may be the real culprit. I don't remember all the details of our previous conversation about it, but I do remember suggesting a way to implement that that fit better with the rest of the pc state information and I expect would make this change unnecessary.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I'll keep that in mind... this is the last bug that I know about that mucks with IT state. If we do find some other issues I'll see if putting it state in the PC helps, but I'm pretty sure matt tried that without success.
    
    
    
   
    2. 

   


  




   







    

     
     

      

       
        

         
          src/arch/arm/predecoder.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Why all the extra blank lines?




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    I went a little over board, I can clean them up.
    
    
    
   
    2.