Review Board 2.0.15


Ruby: enable multiple sequencers in one controller.

Review Request #624 - Created March 31, 2011 and submitted

Information
Lisa Hsu
gem5
Reviewers
Default
ali, gblack, nate, stever 
Ruby: enable multiple sequencers in one controller.

   

  


 


 

  

  









  
 


  

 


















 

  


 


  




   
Ship it!



   

   
Nilay Vaish

   
Posted  (March 31, 2011, 7:22 a.m.)


  


  


  

   
I hope you have tested the existing protocols with these changes.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Yes - MOESI_[CMP_[directory|token]|hammer] all compile and run -l 1000 -n 4 on the Ruby Tester.  Since no logic has changed (for all my Ruby changes), I believe it's sufficient testing, since the MSB in correctness is compilation.
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    That should be sufficient.
    
    
    
   
    3. 

   


  





  

 


  

 

















 



 

  


 


  



   

   
Brad Beckmann

   
Posted  (March 31, 2011, 8:58 a.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/mem/slicc/symbols/StateMachine.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Do you also need to declare the contains_dma_sequencer flag here and set it to False?




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Brad, great catch - since contains_sequencer is no longer used at all, it should be s/contains_sequencer/contains_dma_sequencer/g.  You pointing this out makes me realize that I have not compiled against FS at all, and I was using regression quick tests as my measuring stick.  I'll add that fix and make sure the protocols compile under FS as well.   This should be the only thing out of all the patches that has anything to do with FS|SE distinction though.
    
    
    
   
    2.